-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polars xlsx_cells
#1358
polars xlsx_cells
#1358
Conversation
🚀 Deployed on https://deploy-preview-1358--pyjanitor.netlify.app |
@@ -462,6 +500,21 @@ def xlsx_cells( | |||
path = load_workbook( | |||
filename=path, read_only=read_only, keep_links=False | |||
) | |||
if engine not in {"pandas", "polars"}: | |||
raise ValueError("engine should be one of pandas or polars.") | |||
base_engine = pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samukweku what are your thoughts on assigning base_engine
whenever we dispatch differently between polars and pandas? Does it make sense for us to use one pattern instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the PR, knowing that there is a question to be resolved nonetheless. I think we should continue it on an issue tracker.
PR Description
Please describe the changes proposed in the pull request:
xlsx_cells
now supports polars.This PR relates to #1352.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.