Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polars xlsx_cells #1358

Merged
merged 61 commits into from
Jun 3, 2024
Merged

polars xlsx_cells #1358

merged 61 commits into from
Jun 3, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 1, 2024

PR Description

Please describe the changes proposed in the pull request:

  • xlsx_cells now supports polars.
jn.xlsx_cells('../Downloads/worked-examples.xlsx',engine='polars',sheetnames='highlights',fill=True).get_column('fill')
Out[101]: 
shape: (8,)
Series: 'fill' [struct[3]]
[
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
        {"solid",{"FFFFFF00","rgb",0.0},{"FFFFFF00","rgb",0.0}}
        {"solid",{"FFFFFF00","rgb",0.0},{"FFFFFF00","rgb",0.0}}
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
        {null,{"00000000","rgb",0.0},{"00000000","rgb",0.0}}
]

This PR relates to #1352.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this May 1, 2024
@ericmjl
Copy link
Member

ericmjl commented May 1, 2024

@@ -462,6 +500,21 @@ def xlsx_cells(
path = load_workbook(
filename=path, read_only=read_only, keep_links=False
)
if engine not in {"pandas", "polars"}:
raise ValueError("engine should be one of pandas or polars.")
base_engine = pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samukweku what are your thoughts on assigning base_engine whenever we dispatch differently between polars and pandas? Does it make sense for us to use one pattern instead?

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the PR, knowing that there is a question to be resolved nonetheless. I think we should continue it on an issue tracker.

@ericmjl ericmjl merged commit 05effaf into dev Jun 3, 2024
4 checks passed
@ericmjl ericmjl deleted the samukweku/polars_xlsx_cells branch June 3, 2024 00:24
samukweku added a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants