Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create polars equivalent of pandas_flavor #1374

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Jun 14, 2024

PR Description

Please describe the changes proposed in the pull request:

  • polars equivalent of pandas_flavor

This PR is related to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl
Copy link
Member

ericmjl commented Jun 14, 2024

@ericmjl
Copy link
Member

ericmjl commented Jun 19, 2024

Whoa, holy smokes, does this actually work, @samukweku?!?!?!

I was expecting the solution to be more complex!

@samukweku
Copy link
Collaborator Author

@ericmjl even i was surprised. Still waiting for the other shoe to fall off.

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOWWW! This is amazing, @samukweku!

This PR alone is worth a minor (equivalent to major while pre-1.0) release. Could you do the honors of cutting a new release please, once I squash and merge?

@ericmjl ericmjl merged commit 7e501bc into dev Jun 20, 2024
4 checks passed
@samukweku
Copy link
Collaborator Author

@ericmjl if it is ok with u, I'd like to get #1377 in before the new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants