-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] maintain sorted array for conditional join #1398
Open
samukweku
wants to merge
24
commits into
dev
Choose a base branch
from
samukweku/non-equi-join-improve
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://deploy-preview-1398--pyjanitor.netlify.app |
samukweku
changed the title
Samukweku/non equi join improve
[ENH] maintain sorted array for conditional join
Sep 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1398 +/- ##
==========================================
- Coverage 89.07% 83.72% -5.35%
==========================================
Files 87 87
Lines 5374 5857 +483
==========================================
+ Hits 4787 4904 +117
- Misses 587 953 +366 |
samukweku
force-pushed
the
samukweku/non-equi-join-improve
branch
from
September 18, 2024 04:24
dc4357c
to
af7ef10
Compare
samukweku
force-pushed
the
samukweku/non-equi-join-improve
branch
from
September 18, 2024 13:04
af7ef10
to
cc66145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of a series of PRs that ultimately adds support for aggregations within
conditional_join
. the numba code now uses an array that is kept sorted, based on grantjenks' sortedcontainers implementation. In one case, perf. improved by about 50x compared to the current implementation; too large a perf diff?PR Description
Please describe the changes proposed in the pull request:
df
orright
is emptyThis PR relates to #1269, #1396 and #1397 .
Please tag maintainers to review.