Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] maintain sorted array for conditional join #1398

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Sep 7, 2024

This is the third part of a series of PRs that ultimately adds support for aggregations within conditional_join. the numba code now uses an array that is kept sorted, based on grantjenks' sortedcontainers implementation. In one case, perf. improved by about 50x compared to the current implementation; too large a perf diff?

PR Description

Please describe the changes proposed in the pull request:

  • maintain a sorted array to get matching indices. this kicks in if there isn't a faster option (monotonic regions)
  • fail early if df or right is empty

This PR relates to #1269, #1396 and #1397 .

Please tag maintainers to review.

@samukweku samukweku self-assigned this Sep 7, 2024
@ericmjl
Copy link
Member

ericmjl commented Sep 7, 2024

@samukweku samukweku marked this pull request as draft September 7, 2024 13:51
@samukweku samukweku changed the title Samukweku/non equi join improve [ENH] maintain sorted array for conditional join Sep 7, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 14 lines in your changes missing coverage. Please review.

Project coverage is 83.72%. Comparing base (6e77fbc) to head (d3c5772).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1398      +/-   ##
==========================================
- Coverage   89.07%   83.72%   -5.35%     
==========================================
  Files          87       87              
  Lines        5374     5857     +483     
==========================================
+ Hits         4787     4904     +117     
- Misses        587      953     +366     

@samukweku samukweku force-pushed the samukweku/non-equi-join-improve branch from dc4357c to af7ef10 Compare September 18, 2024 04:24
@samukweku samukweku marked this pull request as ready for review September 18, 2024 12:59
@samukweku samukweku marked this pull request as draft September 18, 2024 13:00
@samukweku samukweku force-pushed the samukweku/non-equi-join-improve branch from af7ef10 to cc66145 Compare September 18, 2024 13:04
@samukweku samukweku marked this pull request as ready for review September 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants