-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalPy support #2859
base: main
Are you sure you want to change the base?
Add GraalPy support #2859
Conversation
_fast_get_system_executable doesn't have side effects, so it was merely asserting that the system python executable ends with a version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried implementing and using this as a plugin first?
Yes, we were shipping a plugin as a part of GraalPy's distribution for several years now. The first part of the plugin source is now exactly the same as the code submitted here. The second part adds an alternative seeder, which we're not submitting here (that part would stay as a plugin, it's not essential for basic operation). The problems with having a plugin are:
Note that uv already supports creating GraalPy virtualenvs out of the box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to fix the CI before we can merge 👍
Cross-referencing cibuildwheel PR: pypa/cibuildwheel#1538 |
I don't understand why those two builds timed out - they seem to just have hung? I ran the check in our fork and it just passed (as I would expect): https://github.com/msimacek/virtualenv/actions/runs/14131798860 Can you just restart the two jobs to double check? |
This adds support for creating GraalPy virtualenvs and add GraalPy to the CI. The added code mostly mirrors PyPy3 implementation.
This PR is picking up from #2832
Addressed #2832 (comment)
Addressed #2832 (comment)
The main addition is that we skip coverage reporting and slower tests on GraalPy, because that pushes the CI very close to the limit (had it passing in just seconds shy of the 20min limit on Ubuntu). Skipping a few slower tests and coverage reporting should make it fit comfortably inside the timeout.
/cc @msimacek