Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement .plot(), .scatterplot() and .lisa_map() methods for Moran_Local object #19

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

implement .plot(), .scatterplot() and .lisa_map() methods for Moran_Local object #19

wants to merge 17 commits into from

Commits on Aug 9, 2018

  1. add .plot(), .scatterplot() and .LISA_map() methods to `esda.Mo… 

    …ran_Local` object

therefore call `splot` functonality
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    33267f6 View commit details
    Browse the repository at this point in the history

  2. add test for methods .plt(), .scatterplot() and .LISA_map() 

    fix parameters in `splot.esda.lisa_cluster()` called in `moran.py`
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    0b02b04 View commit details
    Browse the repository at this point in the history

  3. add matplotlib and splot install to .travis.yml

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    475628e View commit details
    Browse the repository at this point in the history

  4. add pip install https://github.com/geopandas/geopandas/archive/maste… 

    …r.zip` to `.travis.yml` for testing
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f220208 View commit details
    Browse the repository at this point in the history

  5. add import warnings to moran.py

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    be4e6a0 View commit details
    Browse the repository at this point in the history

  6. debug test_moran.py 

    change `self = moran.Moran_Local(self.y, self.w)` to `mloc = moran.Moran_Local(self.y, self.w)`
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    60c458c View commit details
    Browse the repository at this point in the history

  7. debug test_moran.py 

    remove `self` inside test funciton for plots
Please enter the commit message for your changes. Lines starting
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1a2308e View commit details
    Browse the repository at this point in the history

  8. update testing in line 69 to `np.testing.assert_allclose(pval, 0.009,… 

    … rtol=1e-7, atol=0)`
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    2345dd9 View commit details
    Browse the repository at this point in the history

  9. set random seed and change reference pval to 0.008 in test_by_col

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    054d331 View commit details
    Browse the repository at this point in the history

  10. try to debug TravisCI package install. 

    also change version number to fix a warning in the TravisCI log
instal matplotlib with conda
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    c571a21 View commit details
    Browse the repository at this point in the history

  11. adapt moran.py and test_moran.py to new splot functionality 

    add examples and documentation
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fb19fb3 View commit details
    Browse the repository at this point in the history

  12. add --yes to matplotlib install in .travis.yml

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    734ac4a View commit details
    Browse the repository at this point in the history

  13. add env MPLBACKEND='pdf' to .travis.yml

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    a0abd72 View commit details
    Browse the repository at this point in the history

  14. change position of MPLBACKEND='pdf' in .travis.yml

    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d6c3988 View commit details
    Browse the repository at this point in the history

  15. add conda install descartes to .travis.yml due to geopandas dep… 

    …endency
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    b6e1b26 View commit details
    Browse the repository at this point in the history

  16. add conda install mapclassify to .travis.yml fro geopandas depe… 

    …ndency

note: this will only work once the PySAL refactore is released
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f15eb1f View commit details
    Browse the repository at this point in the history

  17. add splot methods to Moran_BV, Moran, Moran_Local and `Moran_… 

    …Local_BV`
    @slumnitz
    slumnitz committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    dcca1da View commit details
    Browse the repository at this point in the history