prototype moran_scatterplot(), plot_moran_simulation() and plot_moran() for esda
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be rebased, I believe? |
Update notebooks. Keep this commit for git cleanup purposes
changed colors fixed call of `seaborn.kdeplot()` by using `ax=ax` as function parameter
same colors for every viz
…)` to `splot.esda`
…atterplot()` set `ax=` in `plot_moran_simulation()` and ix `nosetest .` error
so it is only triggered when bokeh is used
|
@ljwolf yes, this needed a rebase. I also added a fix in |
4 tasks
|
Great ok. is this waiting for anything more? |
|
no this one is all ready to go, if you agree with it. |
|
I do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prototype and implement
moran_scatterplot(),plot_moran_simulation()andplot_moran()foresdazstandardargument to existing moran viz for consistency