Better worker.py path for GitHub pages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed the wrong absolute URL was not working on GitHub pages so I've fixed it.
I know it's not idea to not being able to refer to the current folder but the thing is that such file could be imported in the VFS at any path level so the root/starting folder is always the one that bootstraps the interpreter, not necessarily the one where the file is.
This has been tested locally and the network related errors are now gone, it should work on GitHub pages too.
P.S. there is another error about MicroPython but it seems unrelated to this change or the previous one with the Service Worker.