Option to use one database when xdist plugin is used #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def is_xdist_one_db_enabled(config): | ||
| from django.conf import settings | ||
| is_sqlite = (settings.DATABASES['default']['ENGINE'] == 'django.db.backends.sqlite3') | ||
| # can't use one sqlite3 db for distributed test run because of lock |
There was a problem hiding this comment.
This should raise a config error probably?
There was a problem hiding this comment.
I'm not really familiar with error handling in pytest, could you give some example or exception class name?
There was a problem hiding this comment.
ValueError might be appropriate.
Closed
blueyed
reviewed
Sep 16, 2018
|
|
||
| one_db = config.getvalue('xdist_one_db') | ||
| if one_db and is_sqlite: | ||
| raise ValueError("xdist-one-db option can not be used together with sqlite3 backend") |
There was a problem hiding this comment.
This might only be true for the :mem: sqlite db, no?
blueyed
reviewed
Sep 16, 2018
| group._addoption('--xdist-one-db', | ||
| dest='xdist_one_db', default=False, action='store_true', | ||
| help="Use only one database with xdist plugin. " | ||
| "Doesn't work with sqlite3 backend due to db lock") |
There was a problem hiding this comment.
Oh, this implies it is true for sqlite in general - but should have a dot at the end.
|
Got stuck again unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this got stuck for some reason: #98