Add --force-short-summary option and extend sequence printing with -vv #13061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
|
@nicoddemus @bluetech @RonnyPfannschmidt @The-Compiler |
RonnyPfannschmidt
approved these changes
Jan 21, 2025
| @@ -1467,7 +1474,9 @@ def _get_line_with_reprcrash_message( | |||
| except AttributeError: | |||
| pass | |||
| else: | |||
| if running_on_ci() or config.option.verbose >= 2: | |||
| if ( | |||
| running_on_ci() or config.option.verbose >= 2 | |||
There was a problem hiding this comment.
This one is getting tricky
But I'm torn about whether there should be a helper
|
Appreciate the review! Happy to help out if/when the verbosity categories come out of limbo; I got a decent amount of familiarity with the current systems putting this PR together, so would be glad to put that to use. Thanks! |
This option allows the users to always see the "short test summary" section regardless of the verbosity level. Fix pytest-dev#12713
nicoddemus
force-pushed
the
test-summary-fix
branch
from
10f84e1 to
d471aef
Compare
nicoddemus
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Thanks @kenny-y-dev for the PR!
Took the liberty of splitting the PR into two commits, so can backport the bugfix. 👍
|
Backport: #13163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12713.
The fix for issue #11777 removed any output shortening in the test summary output when
-vvis used, leading to potentially long/redundant summary messages. The issue in #11777 is also now fully fixed, as series were still condensed in output even with full verbosity.Since the removal of the summary shortening has been in place for a while, the addition of a new runtime option seemed to be the best way to address #12713 without changes to existing functionality.
--force-short-summarywas added to always show a shortened summary message regardless of the verbosity setting. Additionally, when using-vv,saferepr_unlimitedis now called to fully resolve #11777.