Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message to highlight solution to user configuration err… #9651

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

beattyml1
Copy link

…or highlighted in issue 8662

Pull Request Check List

Resolves: #8662

Provides additional help text error message for Warning: The current project could not be installed. I know the issue above is closed but I think this is also very helpful for helping people to understand issue. If you don't agree I won't raise a fuss just thought I'd offer to add add the help text to the error message that would have helped me.

  • [N/A] Added tests for changed code.
    • Checked for existing code for tests related to this error message
    • No control flow to change just a error message text
    • Tests still pass on local
  • [N/A] Updated documentation for changed code.

Comment on lines +204 to +205
"If you did intend to install the current project please make sure"
" you set the packages setting in your pyproject.toml file.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"If you did intend to install the current project please make sure"
" you set the packages setting in your pyproject.toml file.\n"
"If you did intend to install the current project you may need"
" to set `packages` in your pyproject.toml file.\n"

I agree it makes sense to provide additional information. I would only rephrase it slightly because setting packages is only required if your package name does not match your project name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No file/folder found for package
2 participants