fix loss of context/cause on exceptions raised inside open_websocket #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shoutout to @graingert for the clean no-copy solution that avoids the issues mentioned in python-trio/flake8-async#298 and python/cpython#125782 |
belm0
approved these changes
Oct 24, 2024
graingert
requested changes
Oct 24, 2024
graingert
reviewed
Oct 26, 2024
graingert
reviewed
Oct 26, 2024
|
you did a merge commit rather than squash & merge... 😢 |
|
Disable the wrong kinds of merge in the repo settings? |
belm0
pushed a commit
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #191
I'm not 100% sure that
copy_excis 100% robust (given that everything seems ever so fickle with copying exceptions), so it may be a good idea to wrap it in atry: exceptthat gives up on copying if anything fails.