Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126433: Fix compiler warnings on 32-bit Windows #126444

Merged
merged 1 commit into from
Nov 5, 2024
Merged

gh-126433: Fix compiler warnings on 32-bit Windows #126444

merged 1 commit into from
Nov 5, 2024
+12 −10

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 5, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 5, 2024
Open
@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2024

I didn't fix these two warnings on purpose, I will fix them separately:

C:\victor\python\main\Modules_hacl\Lib_Memzero0.c(39,27): warning C4244: 'function': conversion from 'uint64_t' to 'SIZE_T', possible loss of data [C:\victor\python\main\PCbuild\pythoncore.vcxproj]
C:\victor\python\main\Modules_interpchannelsmodule.c(2096,30): warning C4244: '=': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data [C:\victor\python\main\PCbuild\pythoncore.vcxproj]

@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2024

cc @sobolevn

sobolevn
sobolevn approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vstinner vstinner merged commit 0b67ce9 into python:main Nov 5, 2024
45 checks passed
@vstinner vstinner deleted the fix_win_warns branch November 5, 2024 15:05
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Nov 14, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0b67ce930a56c4ffd597b1a658ddcbacfb40e798 3.13

@bedevere-app
Copy link

bedevere-app bot commented Nov 14, 2024

GH-126827 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 14, 2024
vstinner added a commit to vstinner/cpython that referenced this pull request Nov 14, 2024
@vstinner
pythongh-126433: Fix compiler warnings on 32-bit Windows (python#126444)
e07c21c 
(cherry picked from commit 0b67ce9)
@vstinner
Copy link
Member Author

Python 3.12 doesn't have these warnings.

vstinner added a commit that referenced this pull request Nov 14, 2024
@vstinner
[3.13] gh-126433: Fix compiler warnings on 32-bit Windows (#126444) (#…
bf6fa21 
…126827)

gh-126433: Fix compiler warnings on 32-bit Windows (#126444)

(cherry picked from commit 0b67ce9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @sobolevn