Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126433: Change channel_info.count to int64_t #126447

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 5, 2024

Fix compiler warnings on 32-bit Windows: change channel_info.count type from Py_ssize_t to int64_t in _interpchannelsmodule.c.

Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
@vstinner
Copy link
Member Author

vstinner commented Nov 6, 2024

cc @ericsnowcurrently @sobolevn

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 09d7083 into python:main Nov 6, 2024
45 checks passed
@vstinner vstinner deleted the fix_win_warns2 branch November 6, 2024 10:31
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Nov 14, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2024
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
(cherry picked from commit 09d7083)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 14, 2024

GH-126826 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 14, 2024
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Nov 14, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 09d7083962062acfef7e7a9a309a01fb70ad8276 3.12

@vstinner vstinner removed the needs backport to 3.12 bug and security fixes label Nov 14, 2024
@vstinner
Copy link
Member Author

Modules/_interpchannelsmodule.c doesn't exist in Python 3.12.

vstinner added a commit that referenced this pull request Nov 14, 2024
…126826)

gh-126433: Change channel_info.count to int64_t (GH-126447)

Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
(cherry picked from commit 09d7083)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants