Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126757: fix minor typo #126758

Merged
merged 1 commit into from
Nov 12, 2024
Merged

gh-126757: fix minor typo #126758

merged 1 commit into from
Nov 12, 2024

Conversation

zhangyx1998
Copy link
Contributor

@zhangyx1998 zhangyx1998 commented Nov 12, 2024 •
edited by bedevere-app bot
Loading

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Nov 12, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Closed
ZeroIntensity
ZeroIntensity approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's not use this as precedent for future cosmetic changes :)

cc @terryjreedy

@brettcannon brettcannon merged commit 8cc6e5c into python:main Nov 12, 2024
49 checks passed
@brettcannon
Copy link
Member

Thanks!

@zhangyx1998 zhangyx1998 deleted the gh-126757 branch November 12, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indentation fix to one line of the source code?
4 participants
@zhangyx1998 @brettcannon @ZeroIntensity @tomasr8