gh-126623: Update libexpat to 2.6.4, make future updates easier #126792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
added
type-security
sethmlarson
force-pushed
the
libexpat-2.6.4
branch
from
97d863d
to
278df3c
Compare
sethmlarson
commented
Nov 13, 2024
| @@ -40,6 +40,10 @@ | |||
| #ifndef Expat_External_INCLUDED | |||
| #define Expat_External_INCLUDED 1 | |||
|
|
|||
| /* Namespace external symbols to allow multiple libexpat version to | |||
| co-exist. */ | |||
| #include "pyexpatns.h" | |||
There was a problem hiding this comment.
Moved this so we have an easier anchor point for sed.
sethmlarson
force-pushed
the
libexpat-2.6.4
branch
from
278df3c
to
1e8a6fb
Compare
gpshead
added
needs backport to 3.9
gpshead
approved these changes
Nov 13, 2024
|
Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2024
…pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c9996909402fadc98e6ca2a64e75a71a7427352) Co-authored-by: Seth Michael Larson <[email protected]>
|
GH-126796 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2024
…pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c99969) Co-authored-by: Seth Michael Larson <[email protected]>
|
GH-126797 is a backport of this pull request to the 3.12 branch. |
|
Sorry, @sethmlarson and @gpshead, I could not cleanly backport this to |
|
Sorry, @sethmlarson and @gpshead, I could not cleanly backport this to |
|
Sorry, @sethmlarson and @gpshead, I could not cleanly backport this to |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Nov 13, 2024
… easier (pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c99969) Co-authored-by: Seth Michael Larson <[email protected]>
|
GH-126798 is a backport of this pull request to the 3.11 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Nov 13, 2024
… easier (pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c99969) Co-authored-by: Seth Michael Larson <[email protected]>
|
GH-126799 is a backport of this pull request to the 3.10 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Nov 13, 2024
…easier (pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c99969) Co-authored-by: Seth Michael Larson <[email protected]>
|
GH-126800 is a backport of this pull request to the 3.9 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Nov 13, 2024
…easier (pythonGH-126792) Update libexpat to 2.6.4, make future updates easier. (cherry picked from commit 3c99969) Co-authored-by: Seth Michael Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades libexpat to 2.6.4 but also adds a
refresh.shscript to make future updates easier. Used therefresh.shscript for HACL* as a reference. Willing to create the backport PRs myself as this diff won't apply cleanly to 3.11 and earlier.cc @hartwork