Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-128911: Add tests on the PyImport C API (GH-128915) (GH-128960) #128989

Merged
merged 2 commits into from
Jan 19, 2025
Merged

[3.12] gh-128911: Add tests on the PyImport C API (GH-128915) (GH-128960) #128989

merged 2 commits into from
Jan 19, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 18, 2025 •
edited
Loading

  • Add Modules/_testcapi/import.c
  • Add Lib/test/test_capi/test_import.py

(cherry picked from commit 34ded1a)

Co-authored-by: Victor Stinner [email protected]
Co-authored-by: Serhiy Storchaka [email protected]
(cherry picked from commit d95ba9f)

@vstinner @serhiy-storchaka
[3.12] [3.13] pythongh-128911: Add tests on the PyImport C API (pytho…
96e0bc4 
…nGH-128915) (pythonGH-128960)

pythongh-128911: Add tests on the PyImport C API (pythonGH-128915)

* Add Modules/_testlimitedcapi/import.c
* Add Lib/test/test_capi/test_import.py
* Remove _testcapi.check_pyimport_addmodule(): tests already covered
  by newly added tests.
(cherry picked from commit 34ded1a)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit d95ba9f)
@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2025
Merged
vstinner
vstinner approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 83de72e into python:3.12 Jan 19, 2025
29 checks passed
@vstinner
Copy link
Member

I merged your PR to avoid conflicts on backporting #128987 to 3.12.

@serhiy-storchaka serhiy-storchaka deleted the backport-34ded1a-3.12 branch January 20, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @vstinner