gh-126835: Move optimization of constant sequence creation from codegen to CFG #129426
+71
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Eclips4
commented
Jan 29, 2025
•
Eclips4
commented
- Issue: Remove the AST optimizer #126835
iritkatriel
reviewed
Jan 29, 2025
iritkatriel
reviewed
Jan 29, 2025
iritkatriel
reviewed
Jan 29, 2025
| @@ -1751,6 +1820,14 @@ optimize_basic_block(PyObject *const_cache, basicblock *bb, PyObject *consts) | |||
| } | |||
| } | |||
| break; | |||
| case BUILD_LIST: | |||
| case BUILD_SET: | |||
| if (i >= oparg) { | |||
There was a problem hiding this comment.
Is it not a compiler bug if i < oparg?
There was a problem hiding this comment.
No, it's not. But if you're asking about removing this condition, I tried it and there was something completely wrong. The address sanitizer reported a heap-buffer-overflow error in that case. You can see this in this PR, before the ea07a50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.