gh-129463: gh-128593: Simplify ForwardRef #129465
Open
+54
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jan 30, 2025
| if self.__cell__ is not None: | ||
| try: | ||
| value = self.__cell__.cell_contents | ||
| except ValueError: | ||
| pass | ||
| else: | ||
| self.__forward_evaluated__ = True | ||
| self.__forward_value__ = value | ||
| return value |
There was a problem hiding this comment.
We can remove this else branch and just write: try: return self.__cell__.cell_contents
| @@ -48,6 +48,7 @@ | |||
| from test.test_inspect import inspect_fodder2 as mod2 | |||
| from test.test_inspect import inspect_stringized_annotations | |||
| from test.test_inspect import inspect_deferred_annotations | |||
| from test.test_typing import EqualToForwardRef | |||
There was a problem hiding this comment.
We try really hard to unwire different test cases, if possible - maybe it would be better to import this object from somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129463. Fixes #128593.
__hash__and__eq__#129463