Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128231: Use runcode() return value for failing early #129488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-128231: Use runcode() return value for failing early #129488

wants to merge 2 commits into from
+40 −3

Conversation

bswck
Copy link
Contributor

@bswck bswck commented Jan 30, 2025 •
edited
Loading

Closes gh-128231.

Any potential downstream subclasses that override runcode() can introduce this protocol gradually, with the old behavior preserved until then (backward compatibility).

@bedevere-app bedevere-app bot mentioned this pull request Jan 30, 2025
Open
@bswck
Copy link
Contributor Author

bswck commented Jan 30, 2025 •
edited
Loading

Should we document the new sentinel? It seems the InteractiveColoredConsole class isn't documented anywhere.

@bswck bswck force-pushed the make-prompts-fail-early-in-repl branch from 1004941 to 71c4a5f Compare January 30, 2025 23:13
@ZeroIntensity ZeroIntensity added the topic-repl Related to the interactive shell label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
awaiting review topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the new REPL, multiline input execution should fail fast
2 participants
@bswck @ZeroIntensity