Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-130160: Convert webbrowser docs to use .. option directive #130497

Closed
wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 24, 2025

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Let's leave easy issues for newcomers ;)


.. option:: -t, --new-tab

Opens the URL in a new browser page ("tab").
Copy link
Member

@hugovk hugovk Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update this too, browser tabs are now well established compared with when this feature was introduced in 2005: e8f244305ef4

(Opera had tabs in 2000, Safari in 2003, IE7 in 2006: https://en.wikipedia.org/wiki/Tab_(interface)#History)

Suggested change
Opens the URL in a new browser page ("tab").
Opens the URL in a new browser tab.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, I missed the label :)

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo Hugo's comment.

@sobolevn sobolevn closed this Feb 24, 2025
@sobolevn
Copy link
Member Author

Let's keep it for someone else :)

@picnixz
Copy link
Member

picnixz commented Feb 24, 2025

Let's keep it for someone else :)

What altruism :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants