Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-130396: Include stack margin for debug windows builds #130554

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Feb 25, 2025

This might only be necessary on Windows debug free-threading builds, but it is simpler and harmless to do this for any Windows debug build.

@markshannon markshannon changed the title GH-130552: Include stack margin for debug windows builds GH-130396: Include stack margin for debug windows builds Feb 25, 2025
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Should we run the buildbot it broke?

@markshannon
Copy link
Member Author

Actually, its a CI job: https://github.com/python/cpython/actions/runs/13527121766/job/37803109505?pr=130550

@markshannon markshannon merged commit 2dad1e0 into python:main Feb 25, 2025
49 checks passed
@markshannon markshannon deleted the more-stack-windows-ft branch February 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants