gh-130959: Reject whitespace in fractions, in pure Python fromisoformat()
#130962
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isoformat()` Fix the pure Python implementation of `fromisoformat()` to reject any non-digit characters, including whitespace, in the fractional part of time specification. This makes the behavior consistent with the C implementation, and prevents incorrect parsing of these fractions (e.g. `.400 ` would be misinterpreted as `.04`).
pganssle
approved these changes
Mar 8, 2025
Misc/NEWS.d/next/Library/2025-03-07-19-24-27.gh-issue-130959.xO8vVS.rst
Outdated
Show resolved
Hide resolved
pganssle
added
3.12
ZeroIntensity
added
needs backport to 3.12
Misc/NEWS.d/next/Library/2025-03-07-19-24-27.gh-issue-130959.xO8vVS.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Paul Ganssle <[email protected]>
|
Thanks! |
mattip
pushed a commit
to pypy/pypy
that referenced
this pull request
Mar 8, 2025
Fix pure Python implementation of `fromisoformat()` to reject spaces in fractional part of time specifications. This matches the behavior of the C implementation in CPython, and prevents the method from parsing them incorrectly. This fixes Django's test suite by enabling a fallback to their own (working) parser. Backports: python/cpython#130962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the pure Python implementation of
fromisoformat()to reject any non-digit characters, including whitespace, in the fractional part of time specification. This makes the behavior consistent with the C implementation, and prevents incorrect parsing of these fractions (e.g..400would be misinterpreted as.04).fromisoformat()handles times with trailing spaces inconsistently with the C extension #130959