-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-130928: Fix error message during bytes formatting for the 'i' flag #130967
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd add a unit test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please, add a unit test :)
And also a NEWS entry. This is a user-visible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think that the fix is correct.
But, let's wait for @serhiy-storchaka review, because his is the code owner.
You can also add yourself to https://github.com/python/cpython/blob/main/Misc/ACKS |
Co-authored-by: sobolevn <[email protected]>
Thanks, but I've already taken advantage of that opportunity earlier |
Error output before correction:
Error output after correction: