Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the "context manager" keyword in concurrent.futures documentation #130976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jstasiak
Copy link
Contributor

@jstasiak jstasiak commented Mar 8, 2025

I was searching for context manager-related part part of this documentation and I couldn't find anything because the words "context manager" weren't actually used anywhere.

I think this will help with discoverability of this feature.


📚 Documentation preview 📚: https://cpython-previews--130976.org.readthedocs.build/

…tion

I was searching for context manager-related part part of this documentation
and I couldn't find anything because the words "context manager"
weren't actually used anywhere.

I think this will help with discoverability of this feature.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 8, 2025
@jstasiak
Copy link
Contributor Author

jstasiak commented Mar 8, 2025

There are more lines changed than strictly necessary because I maintained the overall line length in that section, let me know if I should do otherwise.

@ZeroIntensity ZeroIntensity added skip issue needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Mar 9, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip issue skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants