Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-88473: Implement fast path in date.today() for date types #130980

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Implement a fast path for :class:`datetime.date` objects in :func:`datetime.date.today`
which results in a 5x performance gain while proper subclasses retain their
previous performance.
44 changes: 30 additions & 14 deletions Modules/_datetimemodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -3259,21 +3259,37 @@ date_fromtimestamp(PyObject *cls, PyObject *obj)
static PyObject *
date_today(PyObject *cls, PyObject *Py_UNUSED(dummy))
{
PyObject *time;
PyObject *result;
time = time_time();
if (time == NULL)
return NULL;
/* Use C implementation to boost performance for date type */
if ((PyTypeObject *)cls == &PyDateTime_DateType) {
struct tm tm;
time_t t;
time(&t);

/* Note well: today() is a class method, so this may not call
* date.fromtimestamp. For example, it may call
* datetime.fromtimestamp. That's why we need all the accuracy
* time.time() delivers; if someone were gonzo about optimization,
* date.today() could get away with plain C time().
*/
result = PyObject_CallMethodOneArg(cls, &_Py_ID(fromtimestamp), time);
Py_DECREF(time);
return result;
if (_PyTime_localtime(t, &tm) != 0) {
return NULL;
}

return new_date_ex(tm.tm_year + 1900,
tm.tm_mon + 1,
tm.tm_mday,
(PyTypeObject*)cls);
}
else {
PyObject *time;
PyObject *result;
time = time_time();
if (time == NULL) {
return NULL;
}

/* Note well: today() is a class method, so this may not call
* date.fromtimestamp. For example, it may call
* datetime.fromtimestamp.
*/
result = PyObject_CallMethodOneArg(cls, &_Py_ID(fromtimestamp), time);
Py_DECREF(time);
return result;
}
}

/*[clinic input]
Expand Down
Loading