Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copybutton messages translatable #27

Closed
wants to merge 1 commit into from

Conversation

ccwang002
Copy link
Contributor

This PR implements #23 which make the messages of copybutton (>>>) translatable.

When I tested my change using the master branch of Python (branch 3.7 doesn't seem to use python-docs-theme), I couldn't get it read my modified layout.html. However, if I manually introduced the change, the pot files would include the new strings and the translation worked.

I think it is better to have someone more familiar with the project structure of PEP 545 to test my implementation before it is merged.

@JulienPalard
Copy link
Member

There's a little issue, the command gathering translations strings:

sphinx-build -Q -b gettext -D gettext_compact=0 Doc pot/

won't pick it up, so translation teams won't see it as a sentence to translate. I don't have the time right now to check if there's a simple way to solve this, maybe Sphinx has a way to look for translations strings in configured theme?

@theacodes
Copy link
Collaborator

These resources might be helpful:

  1. Add localization language support readthedocs/sphinx_rtd_theme#403
  2. Added localization language support readthedocs/sphinx_rtd_theme#405

@septatrix
Copy link
Contributor

I think I looked into this in the past and it was possible to directly translate the strings in the javascript file

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@hugovk
Copy link
Member

hugovk commented Apr 6, 2025

@tomasr8 Can this be closed now #225 is merged?

@tomasr8
Copy link
Member

tomasr8 commented Apr 6, 2025

I believe so, the button title is now properly i18n'd.

@hugovk hugovk closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants