Back out "Replace LR access with wrapper"

fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py

@@ -2897,15 +2897,6 @@ def set_learning_rate(self, lr: float) -> None:
             )
         self._set_learning_rate(lr)
 
-    def get_learning_rate(self) -> float:
-        """
-        Sets the learning rate.
-
-        Args:
-            lr (float): The learning rate value to set to
-        """
-        return self.optimizer_args.learning_rate
-
     @torch.jit.ignore
     def update_hyper_parameters(self, params_dict: Dict[str, float]) -> None:
         """

fbgemm_gpu/fbgemm_gpu/tbe/ssd/training.py

@@ -1820,15 +1820,6 @@ def set_learning_rate(self, lr: float) -> None:
         """
         self._set_learning_rate(lr)
 
-    def get_learning_rate(self) -> float:
-        """
-        Sets the learning rate.
-
-        Args:
-            lr (float): The learning rate value to set to
-        """
-        return self.optimizer_args.learning_rate
-
     @torch.jit.ignore
     def _set_learning_rate(self, lr: float) -> float:
         """

fbgemm_gpu/test/tbe/training/backward_adagrad_global_weight_decay_test.py

@@ -190,7 +190,7 @@ def apply_gwd(
             apply_gwd_per_table(
                 prev_iter_values,
                 weights_values,
-                emb.get_learning_rate(),
+                emb.optimizer_args.learning_rate,
                 emb.optimizer_args.weight_decay,
                 step,
                 emb.current_device,

fbgemm_gpu/test/tbe/utils/split_embeddings_test.py

@@ -593,7 +593,9 @@ def test_update_hyper_parameters(self) -> None:
             key: value + 1.0 for key, value in hyperparameters.items()
         } | {"lr": 1.0, "lower_bound": 2.0}
         cc.update_hyper_parameters(updated_parameters)
-        self.assertAlmostEqual(cc.get_learning_rate(), updated_parameters["lr"])
+        self.assertAlmostEqual(
+            cc.optimizer_args.learning_rate, updated_parameters["lr"]
+        )
         self.assertAlmostEqual(cc.optimizer_args.eps, updated_parameters["eps"])
         self.assertAlmostEqual(cc.optimizer_args.beta1, updated_parameters["beta1"])
         self.assertAlmostEqual(cc.optimizer_args.beta2, updated_parameters["beta2"])