Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch depends on custom actions stored in contributor personal repos #242

Open
zxiiro opened this issue Jul 17, 2024 · 4 comments
Open
Assignees

Comments

@zxiiro
Copy link
Collaborator

zxiiro commented Jul 17, 2024

There's a few GitHub actions that PyTorch depends on that appear to be stored in personal repos of some contributors. This is a risk as the team cannot easily update these actions if the contributor is not available for whatever reason. We should standardize on storing any custom actions in a PyTorch controlled repo.

Here's a list of actions that I believe maybe personal repos:

@zxiiro zxiiro assigned zxiiro and unassigned zxiiro Jul 22, 2024
@zxiiro
Copy link
Collaborator Author

zxiiro commented Jul 22, 2024

Discussed this with @seemethere, @ZainRizvi, and @jeanschmidt over Slack. There was agreement that this should be moved to a more central location and we decided that putting these actions into test-infra is probably the best place at the moment.

This is low priority but I'll look into moving some of these repos.

@jwagantall jwagantall self-assigned this Dec 5, 2024
@jwagantall
Copy link
Collaborator

@zxiiro Working on this, so if I understood correctly:

These actions are going to be moved from the private repos into test-infra right?
Any workflows using these actions will also need to be updated which that would include test-infra itself and the main pytorch repos? Do I need to cover other repos?

@zxiiro
Copy link
Collaborator Author

zxiiro commented Dec 9, 2024

I don't know what other repos use these. I've only checked pytorch/pytorch. At one of the CI Sync meetings though we did agree that pytorch/test-infra was likely the best place.

jwagantall added a commit to jwagantall/test-infra that referenced this issue Dec 13, 2024
We are migrating this action "malfet/checkout@silent-checkout"
into test-infra to have all the code hosted in our public repos.
Code origin: https://github.com/malfet/checkout/tree/silent-checkout

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
@jwagantall
Copy link
Collaborator

Follow up on this:

  • malfet/checkout@silent-checkout
    • There is a similar feature in a later version of the original checkout action. Checking with Nikita as it would be a better option to
      just follow a later version of the forked checkout action
  • nick-fields/retry@3e91a01
  • nick-fields/[email protected]
    • This can potentially be left like it is since there are few contributors behind this action which is beneficial
  • seemethere/download-artifact-s3
  • seemethere/upload-artrifact-s3@v5
    • Looking on what are the changes added to this forked action to see if we can go back to using the original
  • necojackarc/auto-request-review@e08cdff

jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 8, 2025
We are migrating to actions/checkout since this action
has all the functionality that was needed in malfet/checkout

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 10, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 10, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 14, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 14, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 14, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 17, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 17, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 17, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 17, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 21, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 21, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 29, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 31, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 31, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 31, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Jan 31, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 1, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 3, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 3, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 5, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 5, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 5, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/upload-artifact-s3 locally
to encorage more coolaboration and maintainance of this action.

This first migration is based on v5.1.0

Issue: pytorch/ci-infra#242

Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 7, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
jwagantall added a commit to jwagantall/test-infra that referenced this issue Feb 11, 2025
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants