Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate S3 actions locally from personal repos #6269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwagantall
Copy link
Contributor

Hosting the code for seemethere/download-artifact-s3 and seemethere/upload-artifact-s3 locally to encorage more coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242

Copy link

vercel bot commented Feb 7, 2025

@jwagantall is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@jwagantall
Copy link
Contributor Author

Creating this consolidated PR (with unit tests) that covers:
#6157
#6158

This PR was created in case the team would prefer to do this migration as a whole instead of sequential PRs

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jwagantall jwagantall force-pushed the migrate-download-upload-s3 branch 2 times, most recently from 0892e90 to 0df3786 Compare February 7, 2025 20:18
@jwagantall jwagantall force-pushed the migrate-download-upload-s3 branch 2 times, most recently from c2eeaca to 3a3572a Compare February 7, 2025 23:06
Hosting the code for seemethere/download-artifact-s3 and
seemethere/upload-artifact-s3 locally to encorage more
coolaboration and maintainance of this action.
This first migration is based on v4.2.0

Issue: pytorch/ci-infra#242
Signed-off-by: Jessica Wagantall <[email protected]>
@jwagantall jwagantall force-pushed the migrate-download-upload-s3 branch from 3a3572a to f3aecb8 Compare February 7, 2025 23:28
# Add npm to PATH only on Windows-based runners
- name: Add npm to PATH
if: contains(runner.os, 'windows') # Conditional check for any Windows OS
run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error test

shellcheck reported issue in this script: SC2086:info:2:1: Double quote to prevent globbing and word splitting
# Add npm to PATH only on Windows-based runners
- name: Add npm to PATH
if: contains(runner.os, 'windows') # Conditional check for any Windows OS
run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error test

shellcheck reported issue in this script: SC2283:error:2:11: Remove spaces around = to assign (or use [ ] to compare, or quote '=' if literal)
# Add npm to PATH only on Windows-based runners
- name: Add npm to PATH
if: contains(runner.os, 'windows') # Conditional check for any Windows OS
run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error test

shellcheck reported issue in this script: SC2086:info:2:42: Double quote to prevent globbing and word splitting
# Add npm to PATH only on Windows-based runners
- name: Add npm to PATH
if: contains(runner.os, 'windows') # Conditional check for any Windows OS
run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error test

shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants