-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ET-VK] Add buffer support for binary ops #9063
Merged
Merged
+132
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context As title; add an implementation for binary operators for buffer-backed tensors. Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 7, 2025
## Context As title; add an implementation for binary operators for buffer-backed tensors. Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/) ghstack-source-id: 270464061 Pull Request resolved: #9063
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9063
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 496cf13 with merge base ddf0d9e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D70810338 |
## Context As title; add an implementation for binary operators for buffer-backed tensors. Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 10, 2025
Pull Request resolved: #9063 ## Context As title; add an implementation for binary operators for buffer-backed tensors. ghstack-source-id: 270464061 @exported-using-ghexport Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
This pull request was exported from Phabricator. Differential Revision: D70810338 |
## Context As title; add an implementation for binary operators for buffer-backed tensors. Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 10, 2025
Pull Request resolved: #9063 ## Context As title; add an implementation for binary operators for buffer-backed tensors. ghstack-source-id: 270797173 @exported-using-ghexport Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
## Context As title; add an implementation for binary operators for buffer-backed tensors. Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 11, 2025
Pull Request resolved: #9063 ## Context As title; add an implementation for binary operators for buffer-backed tensors. ghstack-source-id: 271044833 @exported-using-ghexport Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
trivedivivek
approved these changes
Mar 11, 2025
e5fd234
into
gh/SS-JIA/193/base
49 of 50 checks passed
SS-JIA
added a commit
that referenced
this pull request
Mar 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9063 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/orig @diff-train-skip-merge --------- Co-authored-by: Stephen Jia <[email protected]>
this broke lint |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
release notes: vulkan
Changes to the Vulkan backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
As title; add an implementation for binary operators for buffer-backed tensors.
Differential Revision: D70810338