Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-VK] Add buffer support for binary ops #9063

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 7, 2025

Stack from ghstack (oldest at bottom):

Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: D70810338

## Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Mar 7, 2025
## Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)

ghstack-source-id: 270464061
Pull Request resolved: #9063
Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9063

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 496cf13 with merge base ddf0d9e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70810338

## Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Mar 10, 2025
Pull Request resolved: #9063

## Context

As title; add an implementation for binary operators for buffer-backed tensors.
ghstack-source-id: 270464061
@exported-using-ghexport

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70810338

## Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Mar 10, 2025
Pull Request resolved: #9063

## Context

As title; add an implementation for binary operators for buffer-backed tensors.
ghstack-source-id: 270797173
@exported-using-ghexport

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
@SS-JIA SS-JIA added the release notes: vulkan Changes to the Vulkan backend delegate label Mar 10, 2025
## Context

As title; add an implementation for binary operators for buffer-backed tensors.

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Mar 11, 2025
Pull Request resolved: #9063

## Context

As title; add an implementation for binary operators for buffer-backed tensors.
ghstack-source-id: 271044833
@exported-using-ghexport

Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
@facebook-github-bot facebook-github-bot merged commit e5fd234 into gh/SS-JIA/193/base Mar 11, 2025
49 of 50 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/193/head branch March 11, 2025 21:24
SS-JIA added a commit that referenced this pull request Mar 11, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #9063 by
@SS-JIA
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/orig
@diff-train-skip-merge

---------

Co-authored-by: Stephen Jia <[email protected]>
@swolchok
Copy link
Contributor

this broke lint

@swolchok
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants