-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: add tosa_spec and et-version info to .tosa files #9308
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9308
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled Job, 1 PendingAs of commit b2288b3 with merge base b8a0edd ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
output_tag<N>.tosa is not very informative. Output files will now be named as output_tag<N>_<tosa_spec>_<et-version>.tosa instead. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I13d75f0c35a023a315283bc14e6de38e932d4f10
80b568a
to
056019e
Compare
Testfails are unrelated |
This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message? |
@larryliu0820 I re-submitted the PR in #9392 |
Hi could you help us point out what error you got from this, to help us knowing how to avoid this better in the future or even better could the internal tests be ported to be runned in github also so we can get proper testing while merging? |
Arm backend output files will now be named as output_tag<tosa_spec>.tosa instead of output_tag.tosa.
cc @digantdesai @freddan80 @per @zingo