Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: add tosa_spec and et-version info to .tosa files #9308

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Mar 17, 2025

Arm backend output files will now be named as output_tag<tosa_spec>.tosa instead of output_tag.tosa.

cc @digantdesai @freddan80 @per @zingo

Copy link

pytorch-bot bot commented Mar 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9308

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 1 Pending

As of commit b2288b3 with merge base b8a0edd (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 17, 2025
output_tag<N>.tosa is not very informative. Output files will now be
named as output_tag<N>_<tosa_spec>_<et-version>.tosa instead.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I13d75f0c35a023a315283bc14e6de38e932d4f10
@zingo
Copy link
Collaborator

zingo commented Mar 18, 2025

Testfails are unrelated

@zingo zingo merged commit 28673ad into pytorch:main Mar 18, 2025
159 of 163 checks passed
@larryliu0820
Copy link
Contributor

This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message?

@oscarandersson8218
Copy link
Collaborator Author

@larryliu0820 I re-submitted the PR in #9392

@zingo
Copy link
Collaborator

zingo commented Mar 19, 2025

Hi @larryliu0820

This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message?

Hi could you help us point out what error you got from this, to help us knowing how to avoid this better in the future or even better could the internal tests be ported to be runned in github also so we can get proper testing while merging?

oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants