Add basic ambiguity check in the tests #9371
Open
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also an example of how to use the new dim_order APIs to detect ambiguity when coming from PyTorch Tensor to ExecuTorch.
digantdesai
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9371
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2adbeb0 with merge base a05c4da ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Gasoonjia
reviewed
Mar 18, 2025
| ), | ||
| check_unambiguous_dim_order=True, | ||
| ) | ||
| except AmbiguousDimOrderError as e: |
There was a problem hiding this comment.
the test right now can be passed when
a. AmbiguousDimOrderError raised, or
b. no error occurs.
b is not what we expected.
I would like to add an assertion in the bottom of try section,
Suggested change
| except AmbiguousDimOrderError as e: | |
| assert False, "This test should be failed" | |
| except AmbiguousDimOrderError as e: |
| for node in gm.graph.nodes: | ||
| if node.op == "call_function": | ||
| tensor = node.meta["val"] | ||
| if not isinstance(tensor, torch.Tensor): |
There was a problem hiding this comment.
Maybe here we need also take care of tensor list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is also an example of how to use the new dim_order APIs to detect
ambiguity when coming from PyTorch Tensor to ExecuTorch.
Test plan