Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorization in elementwise_util (not working yet) #9432

Draft
wants to merge 2 commits into
base: gh/swolchok/385/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

this works with op_mul, which is vectorized-friendly, but doesn't work
when we roll out to pattern.h because those ops will not work with
Vectorized yet. See TODO in elementwise_util.h

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9432

Note: Links to docs will display an error until the docs builds have been completed.

❌ 69 New Failures

As of commit 2d19e75 with merge base a5d64cf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 20, 2025
this works with op_mul, which is vectorized-friendly, but doesn't work
when we roll out to pattern.h because those ops will not work with
Vectorized yet. See TODO in elementwise_util.h

ghstack-source-id: 30d2311bed080c3a5390ab00ca20a1e33563f077
ghstack-comment-id: 2738665976
Pull Request resolved: #9432
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@swolchok swolchok marked this pull request as draft March 20, 2025 02:48
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 20, 2025
this works with op_mul, which is vectorized-friendly, but doesn't work
when we roll out to pattern.h because those ops will not work with
Vectorized yet. See TODO in elementwise_util.h

ghstack-source-id: d546d5d595929e84814aa38833c8a07bf3cf6ec5
ghstack-comment-id: 2738665976
Pull Request resolved: #9432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants