Skip to content

Commit

Permalink
Remove unused-variable in kineto/libkineto/src/RoctracerLogger.cpp +3
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

#buildsonlynotests - Builds are sufficient

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D66330328

fbshipit-source-id: 16b9fd6fec99f0e4b18ac2814183df3541fd5cd0
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 22, 2024
1 parent 596126c commit 5ca93a3
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions libkineto/src/RoctracerLogger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,6 @@ void RoctracerLogger::activity_callback(
const char* begin,
const char* end,
void* arg) {
RoctracerLogger* dis = &singleton();

// Log latest completed correlation id. Used to ensure we have flushed all
// data on stop
std::unique_lock<std::mutex> lock(s_flush.mutex_);
Expand Down

0 comments on commit 5ca93a3

Please sign in to comment.