Ignore pop from an empty external ids stack in RoctracerLogger to avoid crash. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id crash. Summary: See D62090845 for the context. This diff is trying to mimic nvidia side behavior. Take a similar workload/application that dyno trace crashes on MI300x, dyno trace on H100 looks like P1666484898. If search for keyword `CUPTI_ERROR_QUEUE_EMPTY` and refer to [nvidia's doc](https://l.facebook.com/l.php?u=https%3A%2F%2Fdocs.nvidia.com%2Fcuda%2Farchive%2F9.2%2Fcupti%2Fgroup__CUPTI__ACTIVITY__API.html%23group__CUPTI__ACTIVITY__API_1g47395bf12ff55f30822d408b940567e3&h=AT1GbJqjqyEYga1oPxXkXPwznRcRGKnHtSlUt_708U3wxjzTel6MJbF2-o7f5yp7pdDKJ5Y_ASuojzFRECp-un81L7PU6GvesQfQ10v7419Eaqm3laLWGZIZldZpczkg37FlbFbI6zC59n6xtOdrscxX-bA), it looks like the suspicious migrated fiber thread attempts to deque from nvidia's thread_local queue fail, just like what we saw on the AMD side. Differential Revision: D64974651
|
This pull request was exported from Phabricator. Differential Revision: D64974651 |
davidberard98
approved these changes
Oct 28, 2024
aaronenyeshi
approved these changes
Oct 28, 2024
|
This pull request has been merged in 5f5dc26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See D62090845 for the context.
This diff is trying to mimic nvidia side behavior.
Take a similar workload/application that dyno trace crashes on MI300x, dyno trace on H100 looks like P1666484898. If search for keyword
CUPTI_ERROR_QUEUE_EMPTYand refer tonvidia's doc, it looks like the suspicious migrated fiber thread attempts to deque from nvidia's thread_local queue fail, just like what we saw on the AMD side.
Differential Revision: D64974651