Fix CPU Trace Message #1018
Closed
Fix CPU Trace Message #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Several users have complained about how the current CPU trace iteration message is confusing. They tend to think that this means there is only one step iteration recorded. Lets change the wording to make it clear it is an entire span that is being recorded. Lets also make it clear this is for specifically CPU Reviewed By: aaronenyeshi Differential Revision: D66683879
|
This pull request was exported from Phabricator. Differential Revision: D66683879 |
aaronenyeshi
approved these changes
Dec 3, 2024
|
This pull request has been merged in 698c71c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Several users have complained about how the current CPU trace iteration message is confusing. They tend to think that this means there is only one step iteration recorded. Lets change the wording to make it clear it is an entire span that is being recorded. Lets also make it clear this is for specifically CPU
Reviewed By: aaronenyeshi
Differential Revision: D66683879