Remove workaround to install kernel-devel #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zxiiro is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
This workaround might not be necessary any longer as kernel-devel appears to be available again in package managers. This also fixes the LF ALI runners as they are failing to fetch from the s3://ossci-linux bucket due to no permissions. Relates to pytorch/pytorch#129880 and pytorch/ci-infra#244. Signed-off-by: Thanh Ha <[email protected]>
zxiiro
force-pushed
the
zxiiro/fix-lf-runner
branch
from
9471651 to
37105e0
Compare
|
I believe it is not required anymore, so we should be OK to remove at this point |
jeanschmidt
approved these changes
Jul 18, 2024
ZainRizvi
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Filed pytorch/ci-infra#246 to track the long term issue of ALI lacking access to s3://ossci-linux, since I suspect that access will have to be granted to make binary builds work there
However, we can test this change just in the ALI runners to verify that it works and revert it otherwise
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround might not be necessary any longer as kernel-devel appears to be available again in package managers. This also fixes the LF ALI runners as they are failing to fetch from the s3://ossci-linux bucket due to no permissions.
I verified by doing a
yum install kernel-develon one of the EC2 instances that was stuck and saw that it returned a newer kernel-devel package.Relates to pytorch/pytorch#129880 and pytorch/ci-infra#244.