Add metric for GitHub API Rate Limit #5654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
zxiiro
force-pushed
the
zxiiro/github-ratelimit
branch
3 times, most recently
from
270d544
to
85c4442
Compare
This captures the rate limit values from GitHub for the ALI account user/process. We can use this to graph and track how much of the API rate limit is used by the CI infrastructure and flag when we are getting too close to the overall limit. Closes: pytorch/ci-infra#273 Signed-off-by: Thanh Ha <[email protected]>
zxiiro
force-pushed
the
zxiiro/github-ratelimit
branch
from
85c4442
to
7af7287
Compare
zxiiro
commented
Sep 12, 2024
| export async function getGitHubRateLimit(installationId: number, metrics: Metrics): Promise<void> { | ||
| const ghAuth = await createGithubAuth(installationId, 'installation', Config.Instance.ghesUrlApi, metrics); | ||
| const githubInstallationClient = await createOctoClient(ghAuth, Config.Instance.ghesUrl); | ||
| const rateLimit = await githubInstallationClient.rateLimit.get(); |
There was a problem hiding this comment.
Calling the RateLimit API does not count towards the rate limit.
It would be more efficient if we can gather this information from an API call that's already happening rather than doing a separate call to the ratelimit API. However I couldn't find where in the code the best place for that would be so I decided on putting in scale-up.
…imit the request frequency to 1 every 10s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This captures the rate limit values from GitHub for the ALI account user/process. We can use this to graph and track how much of the API rate limit is used by the CI infrastructure and flag when we are getting too close to the overall limit.
Closes: pytorch/ci-infra#273