Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Mac wheels in CI #213

Closed
wants to merge 1 commit into from
Closed

Build Mac wheels in CI #213

wants to merge 1 commit into from

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Sep 18, 2024

WIP. Current status:

  1. Building the wheel from the non-GPL FFmpeg S3 binaries seemingly succeeds. The wheel is successfully uploaded as a part of its job.
  2. Downloading the wheel in a subsequent job succeeds.
  3. All installations succeed, including the wheel and all runtime dependencies.
  4. Smoke test fails. See a failing job for logs.
    • We get a segfault at runtime. I've hacked the C++ code to determine where, exactly, the segfault happens, and it's a line of code that does not seem to be a logic error of any kind.
    • In support of the notion that it's not a logic error, when everything is built and tested in the same environment using the S3 binaries, all tests pass.
    • Memory corruption of some kind seems more likely, and that would indicate there is something wrong with how the wheel is constructed. That is, if it was the binaries alone, I think that would show itself in what we have currently committed, which builds from S3 binaries and tests in the same job.
    • I cannot find anything obvious when I dig into the libraries in the wheel. All of the FFmpeg libraries are loaded dynamically, and it's very strange that we fail at this point in the code, as opposed to when we try to call an FFmpeg function.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 18, 2024
@scotts scotts force-pushed the main branch 29 times, most recently from c744fa2 to 20ef92e Compare September 19, 2024 02:00
@scotts scotts force-pushed the main branch 12 times, most recently from 74c72b5 to d4f77f9 Compare September 20, 2024 19:15
@scotts
Copy link
Contributor Author

scotts commented Sep 27, 2024

Closing in favor of PR #230. I accidentally did this work directly on main; #230 moves the changes to a different branch.

@scotts scotts closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants