Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fps info to samplers benchmark #294

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

NicolasHug
Copy link
Member

Output now looks like

----------
num_clips = 1
clips_at_random_indices     med = 12.57ms +- 3.51  med fps = 795.5
clips_at_regular_indices    med = 8.60ms +- 0.55  med fps = 1163.3
clips_at_random_timestamps  med = 16.37ms +- 3.86  med fps = 610.9
clips_at_regular_timestamps med = 9.77ms +- 0.97  med fps = 1023.7
----------
num_clips = 50
clips_at_random_indices     med = 95.78ms +- 3.56  med fps = 5220.2
clips_at_regular_indices    med = 101.75ms +- 2.90  med fps = 4914.1
clips_at_random_timestamps  med = 100.78ms +- 2.34  med fps = 4961.4
clips_at_regular_timestamps med = 106.48ms +- 3.71  med fps = 4601.9

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 25, 2024
@ahmadsharif1
Copy link
Contributor

Can you output the video as well?

Long term you can output the codec and resolution as well. We do the same in benchmark_decoders.py and should probably make it into a common function later.

@NicolasHug
Copy link
Member Author

If that's OK I'll wait until the benchmark supports arbitrary videos. It's definitely in scope for the future

@NicolasHug NicolasHug merged commit 17722e0 into pytorch:main Oct 25, 2024
32 of 40 checks passed
@NicolasHug NicolasHug deleted the sampler_fps branch October 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants