-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds more collectives to ProcessGroups #108
Draft
allenwang28
wants to merge
15
commits into
pytorch:main
Choose a base branch
from
allenwang28:coll
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuation of work for #97.
This PR:
process_group_test.py
to accommodate the above collectivesConcerns and possible follow up actions
Missing ops in backends
Notably
allgather_into_tensor_coalesced
andreduce_scatter_tensor_coalesced
were not added in this PR.It was part of the plan, but started seeing an error such as:
This was confusing, but surely enough this is true, if we do
dir(pg)
we see:After some digging I realized it was because
ProcessGroupNCCL
(and other pg backends) inherit collectives that are defined here, which does not includeallgather_into_tensor_coalesced
orreduce_scatter_tensor_coalesced
. This is confusing since we know that e.g.allgather_into_tensor_coalesced
is implemented for theProcessGroupNCCL
backend.This will likely require changes in PyTorch to enable, so we defer to a future PR.
Test complexity, runtime and coverage
Tests are taking longer and could benefit from more coverage.
process_group_test.py
currently tests all of the collectives, often including the creation/teardownGlooProcessGroup
s andNCCLProcessGroup
s. This takes awhile, but e.g. send/recv needs to be modeled in this way to work correctly so we added tests for gloo and NCCL (test_gloo_send_recv
,test_baby_gloo_send_recv
, andtest_baby_nccl_send_recv_2gpu
).This style of testing is fairly comprehensive and representative, but it's not straightforward how to get this coverage on all collectives while balancing the test runtime. This PR alone increases the execution time of this test file from 15s to 32.66s which is concerning.