ProcessGroupNCCL,Manager: surface async abort errors correctly #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mechanism for propagating abort errors to Manager via
ProcessGroup.errored()
.Without this change we don't wait for all operations to complete in
Manager.should_commit
and even if an abort occurs we don't detect it as they're running asynchronously on the GPU and NCCL abort causes it to return successfully.This intentionally adds a synchronization point in
should_commit
.This also includes a small fix in the resiliency tests to avoid stream dependencies between different worker threads.
Test plan: