Skip to content

Commit

Permalink
Further specify pyre fixmes in runner (#814)
Browse files Browse the repository at this point in the history
Summary:
Make pyre fixme comments more specific.

This diff is mainly to test committing to OSS, changes have no real impact.

Differential Revision: D53363317
  • Loading branch information
ishachirimar authored Feb 5, 2024
1 parent 291e845 commit 11b3fa3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions torchx/runner/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def __init__(
self._name: str = name
self._scheduler_factories = scheduler_factories
self._scheduler_params: Dict[str, object] = scheduler_params or {}
# pyre-ignore[24]: Scheduler opts
# pyre-fixme[24]: SchedulerOpts is a generic, and we don't have access to the corresponding type
self._scheduler_instances: Dict[str, Scheduler] = {}
self._apps: Dict[AppHandle, AppDef] = {}

Expand Down Expand Up @@ -637,7 +637,7 @@ def list(
app.app_handle = make_app_handle(scheduler, self._name, app.app_id)
return apps

# pyre-fixme: Scheduler opts
# pyre-fixme[24]: SchedulerOpts is a generic, and we don't have access to the corresponding type
def _scheduler(self, scheduler: str) -> Scheduler:
sched = self._scheduler_instances.get(scheduler)
if not sched:
Expand All @@ -655,7 +655,7 @@ def _scheduler_app_id(
self,
app_handle: AppHandle,
check_session: bool = True
# pyre-fixme: Scheduler opts
# pyre-fixme[24]: SchedulerOpts is a generic, and we don't have access to the corresponding type
) -> Tuple[Scheduler, str, str]:
"""
Returns the scheduler and app_id from the app_handle.
Expand Down

0 comments on commit 11b3fa3

Please sign in to comment.