Fix logging for torchX command line to remove extra prefix #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69641309 |
kiukchung
approved these changes
Feb 14, 2025
) Summary: The issue is here. The tee_logs was changed to support MVAI so this diff makes the MVAI case an option and defaults to the old call. for example, before, the line is: trainer/0 [1]:I0210 16:15:39.768000 3837215 gen_ai/genie_projects/llm/metaformers/train.py:830] Training starts ... but now, it is: I0210 16:15:40.036000 3378434 torchx/util/log_tee_helpers.py:105] trainer/0 [1]:I0210 16:15:39.768000 3837215 gen_ai/genie_projects/llm/metaformers/train.py:830] Training starts .. Differential Revision: D69641309
andywag
force-pushed
the
export-D69641309
branch
from
a1516ca to
35bf82d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69641309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The issue is here. The tee_logs was changed to support MVAI so this diff makes the MVAI case an option and defaults to the old call.
for example,
before, the line is:
trainer/0 [1]:I0210 16:15:39.768000 3837215 gen_ai/genie_projects/llm/metaformers/train.py:830] Training starts ...
but now, it is:
I0210 16:15:40.036000 3378434 torchx/util/log_tee_helpers.py:105] trainer/0 [1]:I0210 16:15:39.768000 3837215 gen_ai/genie_projects/llm/metaformers/train.py:830] Training starts ..
Differential Revision: D69641309