Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tee argument #808

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Tee argument #808

merged 3 commits into from
Jan 30, 2024

Conversation

ccharest93
Copy link
Contributor

@ccharest93 ccharest93 commented Jan 23, 2024

Added Tee as an argument which default to it's old value of 3.

#805

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2024
Copy link
Collaborator

@kiukchung kiukchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ccharest93 ccharest93 requested a review from kiukchung January 24, 2024 21:50
@ccharest93
Copy link
Contributor Author

ccharest93 commented Jan 24, 2024

oups sorry re-requested review on the wrong one, whats the next steps needed to merge this? It says workflow awaiting approval

@kiukchung kiukchung merged commit f447bed into pytorch:main Jan 30, 2024
13 of 21 checks passed
@kiukchung
Copy link
Collaborator

oups sorry re-requested review on the wrong one, whats the next steps needed to merge this? It says workflow awaiting approval

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants