fix warning B908 #816
Merged
fix warning B908 #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53461157 |
yikaiMeta
added a commit
to yikaiMeta/torchx
that referenced
this pull request
Feb 6, 2024
Summary: Fix the warning on the code: B908: Contexts with exceptions assertions like with self.assertRaises or with pytest.raises should not have multiple top-level statements. Each statement should be in its own context. That way, the test ensures that the exception is raised only in the exact statement where you expect it. This warning is raised by flake8-bugbear: https://github.com/PyCQA/flake8-bugbear This diff fixed it by mimicking D50647471. Reviewed By: ishachirimar Differential Revision: D53461157
yikaiMeta
force-pushed
the
export-D53461157
branch
from
9ee11f3 to
e46ae4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53461157 |
|
test comment. |
Summary: Fix the warning on the code: B908: Contexts with exceptions assertions like with self.assertRaises or with pytest.raises should not have multiple top-level statements. Each statement should be in its own context. That way, the test ensures that the exception is raised only in the exact statement where you expect it. This warning is raised by flake8-bugbear: https://github.com/PyCQA/flake8-bugbear This diff fixed it by mimicking D50647471. Reviewed By: ishachirimar Differential Revision: D53461157
yikaiMeta
force-pushed
the
export-D53461157
branch
from
e46ae4f to
126b726
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53461157 |
manav-a
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the warning on the code:
B908: Contexts with exceptions assertions like with self.assertRaises or with pytest.raises should not have multiple top-level statements. Each statement should be in its own context. That way, the test ensures that the exception is raised only in the exact statement where you expect it.
This warning is raised by flake8-bugbear: https://github.com/PyCQA/flake8-bugbear
This diff fixed it by mimicking D50647471.
Differential Revision: D53461157