Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): add support for Spaceship #907

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(provider): add support for Spaceship #907

wants to merge 5 commits into from

Conversation

amroessam
Copy link
Contributor

Hey @qdm12, I'm back with another dns provider, can I please get a review 🙏🏽

qdm12
qdm12 reviewed Jan 11, 2025
View reviewed changes
Copy link
Owner

@qdm12 qdm12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎖️ !!

@amroessam
Copy link
Contributor Author

@qdm12 thanks for the quick feedback, I'll action them promptly 🙏🏽

@amroessam
Copy link
Contributor Author

@qdm12 idk how to resolve the markdown link dead issue 😅
It's an authenticated page!

@amroessam
Copy link
Contributor Author

@qdm12 any luck here 🙏🏽

@amroessam
Copy link
Contributor Author

Hey @qdm12, do you think you can merge this soon? 🙏🏽

@Neustradamus
Copy link

@qdm12: What do you think about this @amroessam PR?

@amroessam
Copy link
Contributor Author

Hey @qdm12 any luck on this? If you wouldn't like to merge it, I can close this PR 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdm12 qdm12 qdm12 left review comments

@yaserleantech yaserleantech yaserleantech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amroessam @Neustradamus @qdm12 @yaserleantech