-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EigenGate equality #7057
Open
daxfohl
wants to merge
11
commits into
quantumlib:main
Choose a base branch
from
daxfohl:fix-eigen-equality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix EigenGate equality #7057
+77
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7057 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 1089 1089
Lines 95232 95199 -33
=======================================
- Hits 93495 93463 -32
+ Misses 1737 1736 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7052. Also fixes #6764.
EigenGates
of the same class generally differ only by the phases that they apply to each eigenspace. Therefore their_value_equality_values_
can be determined uniquely by calculating these phases. This is both faster (no need to calculate the period or canonical exponent) and more robust (exponentiation of phases is accounted for) than the existing implementation. The simplification also allows it to handle large global shifts that cause division-by-zero errors in period calculations (#6764). Additionally, many different edge cases with symbolic exponents are easier to identify and account for.This also allows us to get rid of some superfluous
_value_equality_values_
implementations in subclasses, except where the eigenspaces themselves are changeable.