Handle the case when observed node placed inside of detached iframe in ie11 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyxarez
force-pushed
the
Fix/IE11-detached-iframe-default-view
branch
from
7febdd2 to
387220c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the case when node that should be observed placed inside of iframe that will be detached in some cases. In Chrome it will work just fine because defaultView there becomes null, but in ie it gets the following structure
That case leads to the error in the isSVGGraphicsElement function due to the lack of SVGElement(as well as other properties)
When getWindowOf returns the window with undefined properties the next step "target instanceof getWindowOf(target).SVGElement" raise an error