URL decode s3 key in s3:ObjectCreated #5692
Conversation
tontinton
force-pushed
the
url-decode-s3-key-in-url
branch
3 times, most recently
from
4c060d0 to
4514f64
Compare
quickwit/Cargo.toml
Outdated
| @@ -271,6 +271,7 @@ ulid = "1.1" | |||
| username = "0.2" | |||
| utoipa = { version = "4.2", features = ["time", "ulid"] } | |||
| uuid = { version = "1.10", features = ["v4", "serde"] } | |||
| urlencoding = "2.1.3" | |||
There was a problem hiding this comment.
Please, insert between ulid and username.
There was a problem hiding this comment.
the percent-encoding lib that is already imported also does this (I don't think a lot of people actually use the term "percent encoding", but it seems it's actually the official name of url encoding 😄 )
| @@ -46,6 +46,7 @@ tokio = { workspace = true } | |||
| tracing = { workspace = true } | |||
| ulid = { workspace = true } | |||
| utoipa = { workspace = true } | |||
| urlencoding = { workspace = true } | |||
There was a problem hiding this comment.
I think r comes before t 😄
tontinton
force-pushed
the
url-decode-s3-key-in-url
branch
from
4514f64 to
2225e01
Compare
|
Hey, currently forking the project for this :) |
|
I was kind of waiting for you to add that test requested by guilload... I'll take a deeper look if there are other places that might be impacted. |
|
@tontinton, LGTM, provided that you add a small test to ensure that url encoded keys are properly decoded and use |
|
Oh crap, I've written a test but didn't push :) |
tontinton
force-pushed
the
url-decode-s3-key-in-url
branch
from
2225e01 to
9778e64
Compare
When a file includes `:`, it gets converted to `%3A`, and doing `GetObject` fails.
tontinton
force-pushed
the
url-decode-s3-key-in-url
branch
from
9778e64 to
69844b0
Compare
When a file includes
:, it gets converted to%3A, and doingGetObjectfails.